build(deps): requests between >=2.32.0,<2.32.3#660
Merged
Conversation
>=2.32.0 for n CVE-2024-35195 fix. <2.32.3 to avoid default certificate loading regression.
eiri
approved these changes
Jun 4, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Constrain requests
>=2.32.0for n CVE-2024-35195 fix.<2.32.3to avoid default certificate loading regression.Fixes: #658
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
Dependency change
What is the current behavior?
Regression loading default certificates with requests
2.32.3prevents validating certifcate paths (and hence connecting).What is the new behavior?
Constrain requests to working versions.
Does this PR introduce a breaking change?
Other information
This is temporary see also:
requeststo avoid regression python-sdk-core#194